Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove observer vm resources #54

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Remove observer vm resources #54

merged 2 commits into from
Jan 19, 2024

Conversation

kohei3110
Copy link
Contributor

@github-actions GitHub Actions
Copy link

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Pusher: @kohei3110, Action: pull_request, Workflow: Deploy an Oracle DB in a Data Guard configuration on Azure with Terraform and Ansible

1 similar comment
@github-actions GitHub Actions
Copy link

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Pusher: @kohei3110, Action: pull_request, Workflow: Deploy an Oracle DB in a Data Guard configuration on Azure with Terraform and Ansible

jfaurskov
jfaurskov requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @kohei3110, just a single thing: Could you remove the public IP address and the NIC for the observer node as well?

@github-actions GitHub Actions
Copy link

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Pusher: @kohei3110, Action: pull_request, Workflow: Deploy Single Instance Oracle DB on Azure with Terraform and Ansible

@github-actions GitHub Actions
Copy link

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Pusher: @kohei3110, Action: pull_request, Workflow: Deploy an Oracle DB in a Data Guard configuration on Azure with Terraform and Ansible

1 similar comment
@github-actions GitHub Actions
Copy link

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Pusher: @kohei3110, Action: pull_request, Workflow: Deploy an Oracle DB in a Data Guard configuration on Azure with Terraform and Ansible

@github-actions GitHub Actions
Copy link

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Pusher: @kohei3110, Action: pull_request, Workflow: Deploy Single Instance Oracle DB on Azure with Terraform and Ansible

jfaurskov
jfaurskov approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfaurskov jfaurskov merged commit fa09603 into main Jan 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaurskov jfaurskov jfaurskov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kohei3110 @jfaurskov